You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
Currently every check class contains a check() method, that executes all the different checks.
Having a large method that often looks for very different issues makes checks different to read and understand.
It also makes it impossible to not run certain checks on a more granular level.
We could use reflection to load the methods contained in a check class. We could then pass the array of obtained method names through a filter, to allow tests to be removed. Finally, we could run all the remaining methods.
This could probably be done in a backwards compatible way. We could investigate how to make sure that only check methods get run, and not things like helper functions.
The text was updated successfully, but these errors were encountered:
Currently every check class contains a
check()
method, that executes all the different checks.Having a large method that often looks for very different issues makes checks different to read and understand.
It also makes it impossible to not run certain checks on a more granular level.
We could use reflection to load the methods contained in a check class. We could then pass the array of obtained method names through a filter, to allow tests to be removed. Finally, we could run all the remaining methods.
This could probably be done in a backwards compatible way. We could investigate how to make sure that only check methods get run, and not things like helper functions.
The text was updated successfully, but these errors were encountered: