Skip to content
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.

Break up checks into smaller methods #292

Open
fklein-lu opened this issue Sep 13, 2015 · 0 comments
Open

Break up checks into smaller methods #292

fklein-lu opened this issue Sep 13, 2015 · 0 comments

Comments

@fklein-lu
Copy link
Contributor

Currently every check class contains a check() method, that executes all the different checks.

Having a large method that often looks for very different issues makes checks different to read and understand.

It also makes it impossible to not run certain checks on a more granular level.

We could use reflection to load the methods contained in a check class. We could then pass the array of obtained method names through a filter, to allow tests to be removed. Finally, we could run all the remaining methods.

This could probably be done in a backwards compatible way. We could investigate how to make sure that only check methods get run, and not things like helper functions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant