Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenGraph metadata tags from "Coming Soon" sites #92385

Closed
gamebits opened this issue Jul 4, 2024 · 5 comments · Fixed by Automattic/jetpack#39012
Closed

Remove OpenGraph metadata tags from "Coming Soon" sites #92385

gamebits opened this issue Jul 4, 2024 · 5 comments · Fixed by Automattic/jetpack#39012
Assignees
Labels
[Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Pri] High Address as soon as possible after BLOCKER issues Private by Default Private Sites [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@gamebits
Copy link

gamebits commented Jul 4, 2024

What

If a wpcom site is marked as "Coming Soon", it should output no OpenGraph tags that social media sites can use to generate thumbnails, descriptions, and other previews of the site.

Judging by #56779 (comment), I presume the current behavior is expected, and that a site should instead be set to "Private" to remove this metadata. Hence I'm submitting this as an enhancement and not a bug.

Why

The front page of a site that is marked as "Coming Soon" still has all the metadata loaded necessary for Slack and Twitter to generate previews of the full site. Here are the OG tags of one such site marked "Coming Soon" with Yoast (wordpress-seo) installed and active:

    <meta property="og:locale" content="en_US" class="yoast-seo-meta-tag"/>
    <meta property="og:type" content="website" class="yoast-seo-meta-tag"/>
    <meta property="og:title" content="Home - by Nijaeri" class="yoast-seo-meta-tag"/>
    <meta property="og:description" content="Who am I? “Zim, Zima, who got de keys to my bimma?” Well, lol, I’m not Beenie Man. My name is Nijaeri (Nigh-jair-ree). It’s an African American variation of the African name Njeri, and so far, it is 100% unique to me!" class="yoast-seo-meta-tag"/>
    <meta property="og:url" content="https://bynijaeri.com/" class="yoast-seo-meta-tag"/>
    <meta property="og:site_name" content="by Nijaeri" class="yoast-seo-meta-tag"/>
    <meta property="article:modified_time" content="2024-06-04T00:16:07+00:00" class="yoast-seo-meta-tag"/>
    <meta property="og:image" content="https://bynijaeri.com/wp-content/uploads/2024/05/about-nj-1.png" class="yoast-seo-meta-tag"/>
    <meta name="twitter:card" content="summary_large_image" class="yoast-seo-meta-tag"/>

Without Yoast:

    		<meta name="description" content="Who am I? “Zim, Zima, who got de keys to my bimma?” Well, lol, I’m not Beenie Man. My name is Nijaeri (Nigh-jair-ree). It’s an African American variation of the African name Njeri, and so far, it is 100% unique to me! Read About https://open.spotify.com/artist/4iHNK0tOyZPYnBU7nGAgpQ?si=A3hldOKJQVGe65vMWJFfsA https://open.spotify.com/track/4EI8VuxUuIHKfafU72emqz?si=71b0e3ae964b4268 R&amp;B Memoirs R&amp;B Memoirs View all Posts Be the&hellip;" />

<!-- Jetpack Open Graph Tags -->
<meta property="og:type" content="website" />
<meta property="og:title" content="by Nijaeri" />
<meta property="og:description" content="Music and life those are my genres" />
<meta property="og:url" content="https://bynijaeri.com/" />
<meta property="og:site_name" content="by Nijaeri" />
<meta property="og:image" content="https://bynijaeri.com/wp-content/uploads/2024/05/about-nj-1.png" />
<meta property="og:image:width" content="378" />
<meta property="og:image:height" content="567" />
<meta property="og:image:alt" content="" />
<meta property="og:locale" content="en_US" />
<meta name="twitter:text:title" content="Home" />
<meta name="twitter:image" content="https://bynijaeri.com/wp-content/uploads/2024/05/about-nj-1.png?w=640" />
<meta name="twitter:card" content="summary_large_image" />

How

The site's settings:

by-nijaeri-settings

by-nijaeri-wpcom

Excerpts of how it appears on Slack and Twitter:

by-nijaeri-slack

by-nijaeri-twitter

@gamebits gamebits added [Feature] Site Settings All other general site settings. [Type] Feature Request Feature requests Private by Default Private Sites [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. labels Jul 4, 2024
@mrfoxtalbot mrfoxtalbot added [Pri] High Address as soon as possible after BLOCKER issues Triaged To be used when issues have been triaged. [Type] Bug and removed [Type] Feature Request Feature requests labels Jul 5, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Jul 5, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Jul 10, 2024

Great catch @gamebits!

I can reproduce it on simple and on AT. Could someone in @Automattic/t-rex or @Automattic/lego take a look at this? Thank you!

@arthur791004
Copy link
Contributor

arthur791004 commented Aug 22, 2024

I'm proposing Automattic/jetpack#39012 to remove the og tags when the privacy of the site is configured to one of below:

  • Coming Soon
  • Public & Prevent 3rd party sharing

@arthur791004
Copy link
Contributor

@gamebits @mrfoxtalbot Do you think it would be better to remove OG tags if the site is Public but disabled Prevent 3rd party sharing? Do our users expect this behavior when they want to prevent 3rd party sharing?

@gamebits
Copy link
Author

gamebits commented Aug 27, 2024

@arthur791004 The "Prevent third-party sharing" setting has this definition:

This option will prevent the site's content from being shared with our licensed network of content and research partners, including those that train AI models.

I think it would be poorly received by our customers if we told them: "For social media optimization and to ensure your content looks correct when shared with your followers, you need to opt into AI models using your content."

Let's keep OG tags enabled or disabled independent of that checkbox.

@mrfoxtalbot
Copy link

+1 to what @gamebits said. We should only remove opengraph tags based on the site's visibility. Private and Coming soon sites should not "leak" any information about the site.

Thank you @arthur791004!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Pri] High Address as soon as possible after BLOCKER issues Private by Default Private Sites [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

Successfully merging a pull request may close this issue.

3 participants