Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Do not land into the Active plugins when there is an error activating an installed plugin #96918

Open
epeicher opened this issue Nov 29, 2024 · 4 comments
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Needs Author Reply [Type] Feature Request Feature requests

Comments

@epeicher
Copy link
Contributor

epeicher commented Nov 29, 2024

What

When Uploading a plugin that cannot be activated, e.g. duplicator, the system navigates to the Active plugins view, but the plugin has not been activated, so it seems it is not there.

After uploading the plugin When clicking in All plugins
Image Image

Steps to reproduce

  1. Go to plugins and Upload a plugin that cannot be activated, e.g. Duplicator
  2. Check that the plugins is filtered by Active plugins, note that Duplicator is not there
  3. Click on All plugins, you can see Duplicator there

Why

Users can think that the plugin was not installed

How

Navigating to the All plugins when installing a plugin

Found in p58i-iNH-p2

@epeicher epeicher added [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Feature Request Feature requests labels Nov 29, 2024
@Robertght
Copy link

@epeicher I'm unable to replicate the page redirect behavior here, but this is what I was able to see instead:

  • It behaves the same if I install it through Calypso, before the site gets AT'ed.
  • It also happens through wp-admin/plugins.php after the site is AT'ed
  • Both land on https://sitename.wpcomstaging.com/wp-admin/index.php?page=duplicator-getting-started
  • Refreshing that page still displays the same content above
  • Moving to the Plugins page, I can confirm the Duplicator plugin is disabled but also displays in the dashboard: RdHcLWk2DtIHqh9ILUSSA5n7A7Dz1BhwVd4ykZ5I.jpg
  • The above 2 steps lasted for about a minute and after refreshing them, I got "Sorry, you are not allowed to access this page.".

I think we should block the users sooner from going through these steps, especially if they manage to "start" something within those plugin settings.

I also pinged in Slack here: p1734693975592679/1734692845.173039-slack-C03TY6J1A but pinging @Automattic/fusion for extra visibility on the current results.

@Robertght
Copy link

@epeicher if you're still able to replicate the initial behavior, could you share a screen recording of this please?

@Robertght
Copy link

Also, pinging @cpapazoglou since we noticed this recent change:

Automattic/jetpack#39775

@cpapazoglou
Copy link
Contributor

Also, pinging @cpapazoglou since we noticed this recent change:

Automattic/jetpack#39775

The Jetpack change is only related to duplicator-pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Needs Author Reply [Type] Feature Request Feature requests
Projects
Development

No branches or pull requests

3 participants