Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Share Params Between Physical and Simulation Testing Launch Files #25

Open
3 tasks
zghera opened this issue Apr 6, 2021 · 2 comments
Open
3 tasks

Share Params Between Physical and Simulation Testing Launch Files #25

zghera opened this issue Apr 6, 2021 · 2 comments
Labels
SLAM and Navigation Related to localization, mapping, and navigation subsystems of the ASS.

Comments

@zghera
Copy link
Member

zghera commented Apr 6, 2021

Description

Once #20 is complete, we still need to tune many of the params related to move_base so that we do not need duplicate param files or other nodes (e.g. static transforms) for simulation vs physical testing.

As of Autonomous-Motorsports-Purdue/AMP_ASSv1#11, the parameter files src/kart_2dnav/params/ that are mostly shared between physical and simulation test launch files match that of the param files in teb_local_planner_tutorials. This is necessary for running the simulation launch file so our simulated kart is scaled properly to the map used for simulation testing (we took our testing map from teb_local_planner_tutorials).

This issue also replaces/includes Autonomous-Motorsports-Purdue/AMP_ASSv1#8. These params will need to be altered to reflect the physical kart parameters. Since many of the params will not be the same as teb_local_planner_tutorials's kart params, the simulation will fail (e.g. kart too close to walls on start).

Sub-tasks

  • Update the robot/sensor specific params in src/kart_2dnav/params/ indicated by the TODOs with direct measurements from the kart or from the Velodyne LiDAR documentation (e.g. sensor range to update the obstacle_range parameter in costmap_common_params).

  • Additionally static transforms for the kart are defined in src/static_tf_config/launch/static_transforms_config.launch. These transform values should be re-measured and verified (originally Update Static Transforms with Correct Values AMP_ASSv1#5).

  • Fix the simulation so that it works with the new parameters. This may mean altering the size of the map we use (size per grid square param for rviz) or creating a new map altogether.

Resources

@zghera zghera self-assigned this Apr 6, 2021
zghera referenced this issue in Autonomous-Motorsports-Purdue/AMP_ASSv1 Apr 6, 2021
The param files associated with move_base.launch were modified to (mostly) match teb_local_planner_tutorials' param files as the simulated kart needed to 'fit' on the simulation track we took from teb_local_planner_tutorials. Create Issue #19 for determine a way to modify the params to meet our karts physical params while also maintaining our ability to test in simulation.
@zghera zghera assigned AMP-Purdue and unassigned zghera and AMP-Purdue Apr 10, 2021
@zghera zghera added bug Something isn't working and removed bug Something isn't working labels Apr 10, 2021
@alanssitis
Copy link
Contributor

@zghera , me and @Reschivon are claiming this issue.

@zghera
Copy link
Member Author

zghera commented Oct 19, 2021

@zghera , me and @Reschivon are claiming this issue.

Sounds good! I am going to merge Autonomous-Motorsports-Purdue/AMP_ASSv1#8 into this issue as they are strongly coupled. So that should hopefully make things less confusing for you guys. Once I update it, I will let you both know!

@zghera zghera added the enhancement New feature or request label Oct 19, 2021
@alanssitis alanssitis added the ASS label Jan 22, 2022
@zghera zghera assigned zghera and unassigned Reschivon Feb 6, 2022
@zghera zghera added the wontfix This will not be worked on label Feb 10, 2022
@zghera zghera removed enhancement New feature or request wontfix This will not be worked on ASS labels Feb 21, 2022
@zghera zghera transferred this issue from Autonomous-Motorsports-Purdue/AMP_ASSv1 Feb 21, 2022
@zghera zghera added the SLAM and Navigation Related to localization, mapping, and navigation subsystems of the ASS. label Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
SLAM and Navigation Related to localization, mapping, and navigation subsystems of the ASS.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants