Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show exposed type value and list of values for exposed type #46

Open
3 tasks
FlorianJacta opened this issue Apr 17, 2023 · 4 comments
Open
3 tasks

Show exposed type value and list of values for exposed type #46

FlorianJacta opened this issue Apr 17, 2023 · 4 comments
Labels
good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@FlorianJacta
Copy link
Member

Description
The goal of this issue would be to always show the exposed type used for the Data node (Tabular Data nodes). We should also be able to see the list of predefined exposed types (pandas, modin) when we edit this property in order to change it easily without going in the documentation.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Propagate any change on the demos and run all of them to ensure there is no breaking change
  • Ensure any change is well documented
@FlorianJacta FlorianJacta added the 📈 Improvement Improvement of a feature. label Apr 17, 2023
@FlorianJacta FlorianJacta changed the title Exposed type value and list of values for exposed type Show exposed type value and list of values for exposed type Apr 17, 2023
@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Apr 17, 2023

I guess we'll have to add a non-restrictive enum to the exposed_type property @jrobinAV ?
What would be the values then ?
Is there a different set of value depending on the storage_type value ?
From the description, I guess the value could also be a user defined python class ?
"enum": [
"modin",
"numpy",
"pandas" (default),
""
]

@FredLL-Avaiga
Copy link
Member

Does "always show the exposed type" mean that you want it to be shown by default in the details view of config @FlorianJacta ?
Should the default value be explicitly "dataframe" or empty ?

@FlorianJacta
Copy link
Member Author

FlorianJacta commented Apr 17, 2023

Yes, that's it, in the details. I think it is an important property for this kind of Data nodes and it might make people understand how from a CSV we have a Pandas dataframe. It is also an essential information for the Data node. The list is 'pandas", 'modin', 'numpy'.

The default property should be 'pandas' but it also depends on the Default configuration of Data nodes of the user. So, I don't know how we can handle this. Am I right @jrobinAV ?

@jrobinAV
Copy link
Member

jrobinAV commented Apr 5, 2024

Yes indeed, we should add the enum values into the schema.

@jrobinAV jrobinAV added 🟩 Priority: Low Low priority and doesn't need to be rushed good first issue New-contributor friendly labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

No branches or pull requests

3 participants