Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better management of properties #92

Open
3 tasks
FlorianJacta opened this issue Nov 13, 2023 · 4 comments
Open
3 tasks

Better management of properties #92

FlorianJacta opened this issue Nov 13, 2023 · 4 comments
Labels
📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents 🔒 Staff only Restricted to CC staff members

Comments

@FlorianJacta
Copy link
Member

Description
This issue aims to simplify the use of Taipy Studio Config.

We should only give the properties available for a storage type and not all the properties. For example, a Pickle Data Node cannot have "has_header", "db_username, "db_port", etc properties. If we only give the possible properties to the user, this will simplify the use of Taipy Studio/ Core, avoid errors and misunderstanding. The documentation on Data Node will also not be needed.

If all the properties of a Data Node are used for a Storage type, the button to add properties should disappear.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Propagate any change on the demos and run all of them to ensure there is no breaking change
  • Ensure any change is well documented
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents labels Nov 13, 2023
@jrobinAV jrobinAV added 🟥 Priority: Critical Must be fixed ASAP 🟨 Priority: Medium Not blocking but should be fixed soon and removed 🟥 Priority: Critical Must be fixed ASAP 🟨 Priority: Medium Not blocking but should be fixed soon labels Feb 23, 2024
@FredLL-Avaiga
Copy link
Member

I thought the user could add its own properties ?

@FlorianJacta
Copy link
Member Author

Taipy Studio Config should not suggest "db_username" for a Pickle Data Node even if they can add more properties to a DataNode Config. I don't see where it is in conflict with this issue

@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Mar 6, 2024

If all the properties of a Data Node are used for a Storage type, the button to add properties should disappear.

that would conflict with this

@FlorianJacta
Copy link
Member Author

I see. You could still have it, but it shouldn't propose anything then. You just have to write your own property.

@jrobinAV jrobinAV added the 🔒 Staff only Restricted to CC staff members label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature. 🟧 Priority: High Stalls work on the project or its dependents 🔒 Staff only Restricted to CC staff members
Projects
None yet
Development

No branches or pull requests

3 participants