From 6ad5065d54165063e94d653eec74e8146e50fcd8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fred=20Lef=C3=A9v=C3=A8re-Laoide?=
 <Fred.Lefevere-Laoide@Taipy.io>
Date: Tue, 27 Dec 2022 15:35:28 +0100
Subject: [PATCH] Per Fab's comments

---
 core/l10n/bundle.l10n.json       | 2 +-
 core/package.json                | 2 +-
 core/src/editors/ConfigEditor.ts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/l10n/bundle.l10n.json b/core/l10n/bundle.l10n.json
index b504544..8194060 100644
--- a/core/l10n/bundle.l10n.json
+++ b/core/l10n/bundle.l10n.json
@@ -1,5 +1,5 @@
 {
-  "Do you really want to definitely delete {0}:{1} from the configuration ?": "Do you really want to definitely delete {0}:{1} from the configuration ?",
+  "Do you really want to permanently delete {0}:{1} from the configuration?": "Do you really want to permanently delete {0}:{1} from the configuration?",
   "Cannot show a {0} entity in a {1} Perpective.": "Cannot show a {0} entity in a {1} Perpective.",
   "Entity {0} Name should not contain space, '.' or be empty or be default '{1}'": "Entity {0} Name should not contain space, '.' or be empty or be default '{1}'",
   "Another {0} entity has the name {1}": "Another {0} entity has the name {1}",
diff --git a/core/package.json b/core/package.json
index 3e7f0f6..6b5cb15 100644
--- a/core/package.json
+++ b/core/package.json
@@ -210,7 +210,7 @@
         },
         {
           "command": "taipy.config.deleteNode",
-          "when": "view == taipy-config-datanodes || view == taipy-config-tasks || view == taipy-config-pipelines || view == taipy-config-scenarios"
+          "when": "view =~ /taipy-config-(datanodes|tasks|pipelines|scenarios)/"
         },
         {
           "command": "taipy.config.revealInExplorer",
diff --git a/core/src/editors/ConfigEditor.ts b/core/src/editors/ConfigEditor.ts
index 20e261f..27e8d49 100644
--- a/core/src/editors/ConfigEditor.ts
+++ b/core/src/editors/ConfigEditor.ts
@@ -137,7 +137,7 @@ export class ConfigEditorProvider implements CustomTextEditorProvider {
   private async deleteConfigurationNode(item: TreeItem) {
     const nodeType = item.contextValue;
     const nodeName = item.label as string;
-    const answer = await window.showWarningMessage(l10n.t("Do you really want to definitely delete {0}:{1} from the configuration ?", nodeType, nodeName), "Yes", "No");
+    const answer = await window.showWarningMessage(l10n.t("Do you really want to permanently delete {0}:{1} from the configuration?", nodeType, nodeName.toLowerCase()), "Yes", "No");
     if (answer === "Yes") {
       const uri = getOriginalUri(item.resourceUri);
       const realDocument = await this.taipyContext.getDocFromUri(uri);