Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace withCheckedThrowingContinuation Calls With withUnsafeThrowingContinuation #288

Open
AlexNsbmr opened this issue Oct 16, 2024 · 1 comment
Labels

Comments

@AlexNsbmr
Copy link

First, thank you for maintaining this awesome library! 🙏

I wanted to report an issue we’re experiencing when using withCheckedThrowingContinuation on iOS 18, which is causing several crashes in our app. After investigating, it seems like replacing withCheckedThrowingContinuation with withUnsafeThrowingContinuation resolves the issue.

For reference, the team at RevenueCat has implemented a similar fix, and you can check out their approach here:
RevenueCat/purchases-ios#4286

Would it be possible to make this update in the library as well?

Thank you for your attention to this issue!

@github-actions github-actions bot added the Stale label Nov 16, 2024
Repository owner deleted a comment from github-actions bot Nov 26, 2024
@AvdLee
Copy link
Owner

AvdLee commented Nov 26, 2024

@AlexNsbmr thanks for letting us know! Feel free to open a PR with the fix, happy to give it a review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants