Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userchrome.js exception in private mode #36

Open
orency opened this issue Sep 13, 2023 · 2 comments
Open

userchrome.js exception in private mode #36

orency opened this issue Sep 13, 2023 · 2 comments

Comments

@orency
Copy link

orency commented Sep 13, 2023

The Addressbar redux v4 in latest userchrome.js can cause some bug in private mode on firefox 117.
when i open firefox in normal mode,everthing works fine.however when i open a private mode window, the url input tool bar can not pop up some suggestions and search engine chooses any more.
And meanwhile i can not use enter to finish input , only way is use mouse to click right arrow in input bar can work.
This unnormal phenomenon will continue happen even if private mode window been closed, unless i close firefox and open it again in normal mode then it will work normally.
I have tried delete Addressbar redux v4 in userchrome.js,then everything back to normal.So i guess the origin of this problem should in this function.

@AveYo
Copy link
Owner

AveYo commented Sep 14, 2023

It is indeed broken.
I have an unpublished version that is close to what I expected, just need to test it a bit.

@AveYo
Copy link
Owner

AveYo commented Sep 15, 2023

@orency,
pushed Addressbar redux v5, you are gonna like it!

  • navigate to input on Enter
    if input contains dot, and not contains space - otherwise do default (search)
  • search for input on Tab
    automatically quotes URLs
  • like before, this only happens on the first entry
    using arrow keys to select another entry uses default Tab action

This is how I imagined it the first time, but never got to fully implement it.

As a bonus, this bypasses a lot of search telemetry that firefox uses / sells (less so on forks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants