Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show class name for command handlers in the navigation pop-up #76

Open
lthoulon-locala opened this issue May 2, 2022 · 0 comments
Open

Comments

@lthoulon-locala
Copy link

lthoulon-locala commented May 2, 2022

Enhancement Description

When I try navigating a command through the plugin's pop-up, it's not very clear what is what.
It would be great to show in the class name where the command is handled. Currently it seems it's only showing the command name itself (which we don't really care about as that's what we're clicking on).

More globally I think you can greatly improve what is shown in this popup for a command. Currently a ctrl+click give much better details. Maybe it would be nice to show both the method name and the class name. Also I'm wondering in case of classic use of the on method name if you could fetch the first parameter class of that method to show it.

Here is an example

Class1 {
	void myMethodName(String str){
		send(MyCommand(str))
	}
}

Class2 {
	void on(SomeEvent evt) {
		send(MyCommand(evt.getStr()))
	}
}

Class3 {
	void handle(MyCommand cmd) {
		...
	}
}

would give something like that

> handle (Class3)
< myMethodName (Class1)
< on SomeEvent (Class2)

Do note that the behavior seems to be different when depending on where you trigger that pop-up. It seem data is missing when you trigger it from the command class itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants