Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group endpoints for duplicate instances #46

Closed
wants to merge 1 commit into from
Closed

group endpoints for duplicate instances #46

wants to merge 1 commit into from

Conversation

tsjohns9
Copy link
Contributor

@tsjohns9 tsjohns9 commented May 27, 2021 •
edited
Loading

resolves #44

  • Mulesoft instances of an API can reflect different contracts of an API. If two instances are found to be the same, meaning they have the same Asset Name, Product Version and Asset Version, then they have the same contract, and they should be reflected in one API Service Revision with the endpoints contained in one API Service Instance.
  • If an API has the same Asset Name, the same Product Version, but a different Asset Version, then may be a different contract, so we will publish it as a new API Service Revision.

@tsjohns9 tsjohns9 changed the title group endpoints for duplicate instances #44 group endpoints for duplicate instances May 27, 2021
@tsjohns9 tsjohns9 changed the title #44 group endpoints for duplicate instances group endpoints for duplicate instances May 27, 2021
sagarkal
sagarkal reviewed May 27, 2021
View reviewed changes
pkg/common/common.go
}
}

port = int32(portInt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this should be
i, err := strconv.ParseInt(portInt, 10, 32)
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that might be better

@tsjohns9 tsjohns9 closed this May 27, 2021
@tsjohns9 tsjohns9 reopened this May 27, 2021
@tsjohns9 tsjohns9 closed this May 27, 2021
@tsjohns9 tsjohns9 added this to the Sprint 90 milestone May 28, 2021
@tsjohns9 tsjohns9 reopened this May 28, 2021
@tsjohns9 tsjohns9 closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarkal sagarkal sagarkal left review comments

@chrisccoy chrisccoy Awaiting requested review from chrisccoy

@Atraya21 Atraya21 Awaiting requested review from Atraya21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 90
Development

Successfully merging this pull request may close these issues.

Add a new endpoint for each instance under a version on Mulesoft
2 participants
@tsjohns9 @sagarkal