Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live test are printing way too much information and is polluting our test output #19835

Closed
maririos opened this issue Mar 25, 2021 · 2 comments · Fixed by #19842
Closed

Live test are printing way too much information and is polluting our test output #19835

maririos opened this issue Mar 25, 2021 · 2 comments · Fixed by #19842
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. test-enhancement

Comments

@maririos
Copy link
Member

This started happening around March 9th and I see if in multiple libraries:

Was this on purpose? if so, is there a way to turn it off?

cc: @JoshLove-msft
FYI @pakrym

@maririos maririos added the Client This issue points to a problem in the data-plane of the library. label Mar 25, 2021
@JoshLove-msft
Copy link
Member

Interesting, it should only be printing the logs for failed tests.

@maririos maririos changed the title Live test are printing way to much information and is polluting our test output Live test are printing way too much information and is polluting our test output Mar 25, 2021
@JoshLove-msft
Copy link
Member

JoshLove-msft commented Mar 25, 2021

I'm guessing something changed in the new version of NUnit - #19282

I think it was this fix - nunit/nunit3-vs-adapter#301

Probably, we can just remove this - https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core.TestFramework/src/TestLogger.cs#L88

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. test-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants