Read aso-controller-settings ConfigMap via volume rather than env variables #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
approved these changes
Jul 31, 2024
|
/ok-to-test sha=27873f2 |
|
I may hold off on merging this until we re-enable KIND tests as they're the primary test of this change. While I've tested it locally and it works it may be safer to wait to merge until those tests are re-enabled. |
|
/ok-to-test sha=27873f2 |
super-harsh
reviewed
Aug 4, 2024
matthchr
force-pushed
the
feature/config-reading-changes
branch
from
27873f2
to
7c36469
Compare
matthchr
changed the title
matthchr
changed the title
|
This has some possible disadvantages during upgrades that change the configmap, as there's just one ConfigMap which means the old pod may exit early (due to configmap change). Need to do some testing around that. |
Moving from a model where we have to explicitly set each secret in the pod env to a model where we just mount the whole secret into the pod. This has the added benefit of allowing us to autodetect secret changes and restart the pod AND means that users can totally omit the secret now as opposed to having to create the secret with empty values.
matthchr
force-pushed
the
feature/config-reading-changes
branch
from
7c36469
to
6783a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from a model where we have to explicitly set each secret in the pod env to a model where we just mount the whole secret into the pod. This has the added benefit of allowing us to autodetect secret changes and restart the pod AND means that users can totally omit the secret now as opposed to having to create the secret with empty values.
If applicable: