Retries cannot be disabled entirely

[nojnhuh]

Here it's documented that to disable retries, the client's RetryAttempts should be set to 1:

go-autorest/autorest/client.go

Lines 169 to 171 in 2fa44cb

	// RetryAttempts sets the total number of times the client will attempt to make an HTTP request.
	// Set the value to 1 to disable retries. DO NOT set the value to less than 1.
	RetryAttempts int

That value is used here:

go-autorest/autorest/azure/rp.go

Line 41 in 2fa44cb

autorest.DoRetryForStatusCodes(client.RetryAttempts, client.RetryDuration, autorest.StatusCodesForRetry...),

And gets passed through to here, where the same value is being interpreted as number of retries beyond the first attempt:

go-autorest/autorest/sender.go

Lines 319 to 322 in 2fa44cb

	func doRetryForStatusCodesImpl(s Sender, r *http.Request, count429 bool, attempts int, backoff, cap time.Duration, codes ...int) (resp *http.Response, err error) {
	rr := NewRetriableRequest(r)
	// Increment to add the first call (attempts denotes number of retries)
	for attempt, delayCount := 0, 0; attempt < attempts+1; {

Setting the client's RetryAttempts to 1 then ultimately results in requests eligible for retry always occurring twice.

[jhendrixMSFT]

This looks to be a doc bug. Setting RetryAttempts to zero will disable retries.

[jhendrixMSFT]

Hmm there might be a bit more to this per #597.

[nojnhuh]

I took a stab at tweaking some of the loop accounting to ensure requests are always tried at least once and so client.RetryAttempts represents retries, not total attempts. To the best of my knowledge, that preserves the existing behavior while allowing RetryAttempts to be 0 to disable all retries. Here's what I have so far: main...nojnhuh:go-autorest:retry-fix

Does that seem like a reasonable approach? If so I can open a PR.