Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestExtensions.TryGetRequestIdentifier and overall usage of "correlationIdentifier" #85

Open
norfas opened this issue Feb 1, 2023 · 0 comments

Comments

@norfas
Copy link

norfas commented Feb 1, 2023

The code from RequestExtensions class quoted below does not make sense, since request?.Headers.TryGetValues(...) call is a "dead code" that has no effect.
And judging by this code I doubt that "correlationIdentifier" is being used to any meaningful purpose in this project.

public static bool TryGetRequestIdentifier(this HttpRequestMessage request, out string requestIdentifier) { request?.Headers.TryGetValues("client-id", out IEnumerable<string> _); requestIdentifier = Guid.NewGuid().ToString(); return true; }

Being used like this:
if (!request.TryGetRequestIdentifier(out correlationIdentifier)) { throw new HttpResponseException(HttpStatusCode.InternalServerError); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant