diff --git a/CHANGELOG.md b/CHANGELOG.md index cf25149f..4a05c4c8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Removed +- Removed IWA from default authentcation mode. ### Changed - Temporarily paused the publishing of Linux binaries. - Upgrade MSAL from `4.59.1` to `4.65.0`. diff --git a/src/AzureAuth.Test/AuthModeExtensionsTest.cs b/src/AzureAuth.Test/AuthModeExtensionsTest.cs index 7a69f157..0d77d915 100644 --- a/src/AzureAuth.Test/AuthModeExtensionsTest.cs +++ b/src/AzureAuth.Test/AuthModeExtensionsTest.cs @@ -38,7 +38,7 @@ public void CombinedAuthMode_Allowed() this.envMock.Setup(e => e.Get(EnvVars.NoUser)).Returns(string.Empty); this.envMock.Setup(e => e.Get("Corext_NonInteractive")).Returns(string.Empty); - var subject = new[] { AuthMode.IWA, AuthMode.Web, AuthMode.Broker }; + var subject = new[] { AuthMode.Web, AuthMode.Broker }; // Act + Assert subject.Combine().PreventInteractionIfNeeded(this.envMock.Object, this.logger).Should().Be(AuthMode.Default); diff --git a/src/AzureAuth/Commands/CommandAad.cs b/src/AzureAuth/Commands/CommandAad.cs index 8653c949..48130f48 100644 --- a/src/AzureAuth/Commands/CommandAad.cs +++ b/src/AzureAuth/Commands/CommandAad.cs @@ -61,7 +61,7 @@ public class CommandAad /// #if PlatformWindows public const string AuthModeHelperText = @"Authentication mode. Repeated invocations allowed. -[default: iwa (Integrated Windows Auth), then broker, then web] +[default: broker, then web] [possible values: all, iwa, broker, web, devicecode]"; #else public const string AuthModeHelperText = @"Authentication mode. Repeated invocations allowed. [default: web] diff --git a/src/MSALWrapper.Test/AuthFlow/AuthFlowFactoryTest.cs b/src/MSALWrapper.Test/AuthFlow/AuthFlowFactoryTest.cs index b1300e93..c025602a 100644 --- a/src/MSALWrapper.Test/AuthFlow/AuthFlowFactoryTest.cs +++ b/src/MSALWrapper.Test/AuthFlow/AuthFlowFactoryTest.cs @@ -111,18 +111,16 @@ public void Broker_Only() [Test] public void Windows10Or11_Defaults() { - this.MockIsWindows(true); this.MockIsWindows10Or11(true); IEnumerable subject = this.Subject(AuthMode.Default); - subject.Should().HaveCount(4); + subject.Should().HaveCount(3); subject .Select(a => a.GetType()) .Should() .ContainInOrder( typeof(CachedAuth), - typeof(IntegratedWindowsAuthentication), typeof(Broker), typeof(Web)); } @@ -130,18 +128,16 @@ public void Windows10Or11_Defaults() [Test] public void Windows_Defaults() { - this.MockIsWindows(true); this.MockIsWindows10Or11(false); IEnumerable subject = this.Subject(AuthMode.Default); - subject.Should().HaveCount(3); + subject.Should().HaveCount(2); subject .Select(a => a.GetType()) .Should() .ContainInOrder( typeof(CachedAuth), - typeof(IntegratedWindowsAuthentication), typeof(Web)); } @@ -159,7 +155,6 @@ public void Windows10Or11_All() .Should() .ContainInOrder( typeof(CachedAuth), - typeof(IntegratedWindowsAuthentication), typeof(Broker), typeof(Web), typeof(DeviceCode)); diff --git a/src/MSALWrapper.Test/AuthModeTest.cs b/src/MSALWrapper.Test/AuthModeTest.cs index d4e9b35f..992bdde1 100644 --- a/src/MSALWrapper.Test/AuthModeTest.cs +++ b/src/MSALWrapper.Test/AuthModeTest.cs @@ -22,9 +22,9 @@ public void AllIsAll() public void WindowsDefaultModes() { var subject = AuthMode.Default; - subject.IsIWA().Should().BeTrue(); subject.IsBroker().Should().BeTrue(); subject.IsWeb().Should().BeTrue(); + subject.IsIWA().Should().BeFalse(); subject.IsDeviceCode().Should().BeFalse(); } diff --git a/src/MSALWrapper/AuthMode.cs b/src/MSALWrapper/AuthMode.cs index 00140481..546be983 100644 --- a/src/MSALWrapper/AuthMode.cs +++ b/src/MSALWrapper/AuthMode.cs @@ -47,7 +47,7 @@ public enum AuthMode : short /// /// Default auth mode. /// - Default = IWA | Broker | Web, + Default = Broker | Web, #else /// /// All auth modes.