Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react 19 to peer deps #7455

Open
lucas-garrido opened this issue Dec 9, 2024 · 4 comments
Open

Add react 19 to peer deps #7455

lucas-garrido opened this issue Dec 9, 2024 · 4 comments
Labels
feature-unconfirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react Needs: Attention 👋 Awaiting response from the MSAL.js team public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@lucas-garrido
Copy link

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

MSAL React (@azure/msal-react)

Public or Confidential Client?

Public

Description

React 19 is now stable could you update the peer dependencies please ?
@lucas-garrido lucas-garrido added feature-unconfirmed question Customer is asking for a clarification, use case or information. labels Dec 9, 2024
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications labels Dec 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Dec 9, 2024
@arjenbloemsma
Copy link

I totally agree with @lucas-garrido. This is currently blocking our app from being upgraded.

@arjenbloemsma arjenbloemsma mentioned this issue Dec 14, 2024
Open
@arjenbloemsma
Copy link

Created a PR to address this: #7467

@ritwickg
Copy link

This complete blocker for any react 19 upgrades with SSO

@arjenbloemsma
Copy link

Just mentioned this in the PR, but will also mention it here:

To unblock my project, I've published a npm package of the msal-react fork. This allows us to keep moving forward and use react 19 in dev and test while the official package has not yet been released. Once the new version of official msal-react is released we can simply change back to that package, rebuild and move on.

For those interested in following a similar approach; https://www.npmjs.com/package/@arjenbloemsma/msal-react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-unconfirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react Needs: Attention 👋 Awaiting response from the MSAL.js team public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arjenbloemsma @ritwickg @lucas-garrido