Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[비즈니스] 서브 스프린트 기능 추가 #578

Merged
merged 11 commits into from
Nov 14, 2024
Merged

[비즈니스] 서브 스프린트 기능 추가 #578

merged 11 commits into from
Nov 14, 2024

Conversation

hoooooony
Copy link
Contributor

@hoooooony hoooooony commented Nov 14, 2024 •
edited
Loading

What is this PR? 🔍

Changes 📝

  • [�x] 모바일 리뷰순 모달 추가
  • 메뉴 이미지 좌우 변경
  • 똑똑한 검색 추가

최대한 기존 틀을 살리면서 수정하다보니 불필요하게 사용된 요소가 많습니다. 특히 pc뷰는 너무 급하게 만들다보니 문제가 될 수 있는 부분이 여럿 존재합니다. qa하면서 크리티컬한 이슈 발견 후 수정하겠습니다.

ScreenShot 📷

  • 리뷰순 모달
image image

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@hoooooony hoooooony changed the base branch from develop to feat/business-sub-sprint November 14, 2024 07:12
@hoooooony hoooooony self-assigned this Nov 14, 2024
@hoooooony hoooooony merged commit c94a77e into feat/business-sub-sprint Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeseungyun chaeseungyun chaeseungyun approved these changes

Assignees

@hoooooony hoooooony

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[비즈니스] 서브스프린트
2 participants
@hoooooony @chaeseungyun