Skip to content
This repository has been archived by the owner on Jul 12, 2018. It is now read-only.

"to be converted later" section in exclude-rules #11

Open
brevilo opened this issue Dec 6, 2012 · 6 comments
Open

"to be converted later" section in exclude-rules #11

brevilo opened this issue Dec 6, 2012 · 6 comments

Comments

@brevilo
Copy link

brevilo commented Dec 6, 2012

This looks like an indicator that the ruleset wasn't fully completed at that time. How about Christian's workspace and those release tags?

@ChristianBeer
Copy link
Member

As far as I'm concerned, my workspace is not needed anymore. It was just a proof of concept that will be replaced by drupal soon and no work is done on this anymore (at least by me).

@brevilo
Copy link
Author

brevilo commented Dec 7, 2012

Thanks for the update Christian! I'll leave this to Rom to decide.

@romw
Copy link
Member

romw commented Dec 7, 2012

Tags and branches 3 years or older I'm not all that worried about.

As far as Christian branch is concerned, the path of least resistance is to leave it as it. If we need it, we can go get it out of SVN.

@brevilo
Copy link
Author

brevilo commented Dec 7, 2012

Ok, let's drop Christian's workspace. However, we already added the other old branches and tags on purpose, why should we exclude those? The problem is, you'll only miss them when you need them, and then it'll be too late. I'd like to understand first why Nicolas excluded them in the first place. To me it seems is if he just didn't have the time to look into their details... Since he seems available again, we should ask him for details.

@romw
Copy link
Member

romw commented Dec 11, 2012

IIRC, prior to the SVN migration we had a different naming scheme for branches and tags and so they wouldn't be picked up by the expressions already defined.

I'm not sure it much matters anyway. I wouldn't expect to be able to build and of the the CVS related commits anyway. Files were typically deleted by deleting the diff file CVS used for tracking changes. Most of those branches and tags would fail to build because of missing files.

One of the main selling points for SVN was that each branch/tag wouldn't be affected by refactoring.

@brevilo
Copy link
Author

brevilo commented Dec 12, 2012

Ok, I think I agree with you to ignore those branches and tags, but let's ask Nicolas about this as well because he seemed to indicate he wanted to actually convert those things as well, just "later".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants