Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

unsafe optimizations #7

Open
Kixunil opened this issue Jul 13, 2022 · 1 comment
Open

unsafe optimizations #7

Kixunil opened this issue Jul 13, 2022 · 1 comment

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 13, 2022

I wonder if it'd be useful to have a feature unsafe-optimizations that turns on unsafe code with the only intention to optimize. Currently the candidate is using [MaybeUninit<u8>; 65] inside SerializedPublicKey. Relies on correct impl in secp256k1 ofc but that one already calls memset on the whole array 🙈

@dr-orlovsky
Copy link
Member

I am not against unsafe when it is behind the feature

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants