Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict_encoding dependency #5

Open
dr-orlovsky opened this issue Aug 26, 2021 · 2 comments
Open

Remove strict_encoding dependency #5

dr-orlovsky opened this issue Aug 26, 2021 · 2 comments
Labels
good first issue Good for newcomers refactoring Refactoring of the existing code upstream Issues blocked by changes that has to be implemented/accepted at upstream
Milestone

Comments

@dr-orlovsky
Copy link
Member

Crates are subjected to be used as a part of wider bitcoin ecosystem and should not be limited to client-side-validation only. Thus, strict encoding implementation for crate-defined types should be done inside strict_encoding crate, like it is done for bitcoin, miniscript, secp256k1 and other non-client-side-validation projects.

@dr-orlovsky dr-orlovsky added good first issue Good for newcomers refactoring Refactoring of the existing code upstream Issues blocked by changes that has to be implemented/accepted at upstream labels Aug 26, 2021
@dr-orlovsky dr-orlovsky added this to the Release 0.5 milestone Aug 26, 2021
@dr-orlovsky dr-orlovsky modified the milestones: v0.5.0, v0.6.0 Nov 21, 2021
@cryptoquick
Copy link
Member

This isn't quite clear. Are you saying, the types like the ones in descriptors/src/descriptor.rs that derive StrictEncode and StrictDecode should be moved into a separate strict_encoding crate? Could conditional compilation and features be used instead?

@dr-orlovsky
Copy link
Member Author

I think that we should wait with this change since I am not sure anymore that this is a good idea

@dr-orlovsky dr-orlovsky modified the milestones: v0.6.0, v1.0.0 Mar 23, 2022
@dr-orlovsky dr-orlovsky modified the milestones: v1.0.0, v0.10.0 Jan 23, 2023
@dr-orlovsky dr-orlovsky modified the milestones: v0.10.0, v0.11.0 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactoring Refactoring of the existing code upstream Issues blocked by changes that has to be implemented/accepted at upstream
Projects
None yet
Development

No branches or pull requests

2 participants