Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance & Clean-up Categories #8

Closed
BoaPi opened this issue Jul 20, 2024 · 3 comments
Closed

Enhance & Clean-up Categories #8

BoaPi opened this issue Jul 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BoaPi
Copy link
Contributor

BoaPi commented Jul 20, 2024

Instead of having only a category "Blast (x)", there should be a different ones for each possible Blast size, e.g. Blast 3 & Blast 5.

This will also help on assigning the correct Legion Specific Wargear and costs to weapons.

Additionally we should remove categories that a present two times.

@BoaPi BoaPi added the enhancement New feature or request label Jul 20, 2024
@the-koetjeboe
Copy link
Collaborator

I found and removed a lot of duplicate LegioX categories, so that part is fixed. I can see Mordaxis has some weapon that reference the blast (x) category, as well as crusade macro charges. Macro charges changes blast 3 to 5, so I guess that is one we need to apply this. Are there any others?

@BoaPi
Copy link
Contributor Author

BoaPi commented Jul 28, 2024

have not found so far any other, but the obvious ones where the legioX. Great to see this cleaned up.

For the blast etc., after I have worked on the "Focused Capacitors", we might not need those additional categories. The moment we move a wargear upgrade to the specific weapon it is affecting, things gets way easier.

So for now I would suggest do nothing here and continue move wargear weapon upgrades to weapons.

@the-koetjeboe
Copy link
Collaborator

Alright, if we run into a weapon upgrade that requires the separate blast things we can do it at that time, The rest is fixed so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants