BAH-3854 | AppointmentEventsAdvice should not throw when older validateAndSave is called

[ibacher]

Apologies for not creating a ticket; my browser and Atlassian cloud are not working at the moment.

In #117, AppointmentEventsAdvice was added to enable publishing events when appointments are created. This advice is bound to the validateAndSave() method on AppointmentService. Unfortunately, there are two validateAndSave() methods on AppoinmentService, one which takes a Supplier<Appointment> and one which just takes an appointment. The advice assumes it is called by the version that takes a Supplier<Appointment> so that if the other one is called, an exception is thrown, aborting the attempt to save.

This PR fixes that by ensuring the advice also works if the first argument is not an appointment. I also added some extra defensive checks to ensure that the Supplier returns an Appointment as expected.

[ibacher]

@gsluthra Could you have someone look at this please?

[ojwanganto]

@angshu this PR is very critical. We encountered the same error and had to customize the code to support our implementations. I will appreciate if we get someone look into this

[gokultw]

In #117, AppointmentEventsAdvice was added to enable publishing events when appointments are created. This advice is bound to the validateAndSave() method on AppointmentService. Unfortunately, there are two validateAndSave() methods on AppoinmentService, one which takes a Supplier<Appointment> and one which just takes an appointment. The advice assumes it is called by the version that takes a Supplier<Appointment> so that if the other one is called, an exception is thrown, aborting the attempt to save.

This PR fixes that by ensuring the advice also works if the first argument is not an appointment. I also added some extra defensive checks to ensure that the Supplier returns an Appointment as expected.

@ojwanganto, I have created a card https://bahmni.atlassian.net/browse/BAH-3854, someone who has bandwidth will pick this up soon.

[rahu1ramesh]

@ibacher @ojwanganto I have approved and merged the changes from the PR. Could you please validate if the issue is resolved? Thank you!

[ojwanganto]

Thanks @rahu1ramesh