Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True False capitalisation issues #2

Closed
nik-hz opened this issue Apr 15, 2024 · 2 comments
Closed

True False capitalisation issues #2

nik-hz opened this issue Apr 15, 2024 · 2 comments

Comments

@nik-hz
Copy link

nik-hz commented Apr 15, 2024

The api does not accept lowercase true and false only True and False.

    comeAlive(index) -> [alive <- True];

Works whereas

    comeAlive(index) -> [alive <- true];

throws

Command failed: tsl synthesize -i tmp.tsl --js
tsl: "True" cannot be part of an AST.
CallStack (from HasCallStack):
  error, called at src/TSL/HOA/Codegen.hs:198:29 in tsl-2.0.0.0-9Ku6Ii70Jk0421RpU1dhV9:TSL.HOA.Codegen
@santolucito
Copy link
Member

The core of this issue is discussed here: Barnard-PL-Labs/tsltools#58

As a stopgap, it may be nice to add a preprocessor and throw a warning if we see either true or True in the spec. Really neither should be there (yet).

I would rather not put this in the tsl-api since I want to keep this as the tiniest wrapper possible. It would be better to put this in tsltools, similar to here: https://github.com/Barnard-PL-Labs/tsltools/blob/57a1d8968e29b51e35e06deea6d2262b4ed3cefb/src/TSL/Preprocessor.hs#L458

@santolucito
Copy link
Member

closing in favor of Barnard-PL-Labs/tsltools#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants