-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NMEA receiving feature (null safety update) #819
Conversation
…functionality to example app
…functionality to example app
…functionality to example app
…d tests to increase code coverage to 100%.
…functionality to example app
…functionality to example app
…functionality to example app
…d tests to increase code coverage to 100%.
version bump
…to issue#516 � Conflicts: � geolocator/CHANGELOG.md � geolocator/README.md � geolocator/example/lib/main.dart � geolocator/pubspec.yaml � geolocator_platform_interface/CHANGELOG.md
This reverts commit 744d09e
more formatting
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 18 +17
Lines 27 277 +250
==========================================
+ Hits 27 277 +250
Continue to review full report at Codecov.
|
Note: to avoid conflicts, I was using my own GitHub fork for the packages, so the analyzer checks failed. I will update their versions, but note that most checks will fail as I have to update the pubspecs for android, geolocator and geolocator_platform_interface. |
Closed in favour of #932 as it implements NMEA with the latest changes. |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
New feature.
There is no current option to receive NMEA messages.
🆕 What is the new behavior (if this is a feature change)?
With this PR, you can receive NMEA messages (only on Android N and above, no iOS due to limitations).
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Closes #605, closes #561
This PR takes most changes from #605 and updates them to null safety and the latest changes from master.
🤔 Checklist before submitting
master
.