We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The !this.options.roof.direction should instead check for null/undefined:
!this.options.roof.direction
null
undefined
OSMBuilding/src/buildingpart.js
Line 179 in 228874c
In JavaScript, 0 is nullish, causing this warning to be printed, if you set the direction of a skillion roof to 0 (north-facing roof).
0
Since 0 is an acceptable roof direction, no warning should be printed.
Minor, since I think it only causes a warning.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
The
!this.options.roof.direction
should instead check fornull
/undefined
:OSMBuilding/src/buildingpart.js
Line 179 in 228874c
In JavaScript,
0
is nullish, causing this warning to be printed, if you set the direction of a skillion roof to0
(north-facing roof).Expected behavior:
Since
0
is an acceptable roof direction, no warning should be printed.Impact:
Minor, since I think it only causes a warning.
The text was updated successfully, but these errors were encountered: