Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roof direction check for skillion #60

Open
justinormont opened this issue Jul 7, 2024 · 0 comments · May be fixed by #61
Open

Roof direction check for skillion #60

justinormont opened this issue Jul 7, 2024 · 0 comments · May be fixed by #61

Comments

@justinormont
Copy link
Contributor

justinormont commented Jul 7, 2024

The !this.options.roof.direction should instead check for null/undefined:

if (this.options.roof.shape === 'skillion' && !this.options.roof.direction) {

In JavaScript, 0 is nullish, causing this warning to be printed, if you set the direction of a skillion roof to 0 (north-facing roof).

Expected behavior:

Since 0 is an acceptable roof direction, no warning should be printed.

Impact:

Minor, since I think it only causes a warning.

@justinormont justinormont linked a pull request Jul 7, 2024 that will close this issue
@justinormont justinormont changed the title Roof Direction Check for Skillion Roof direction check for skillion Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant