Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /champions #9

Open
Bekabyx opened this issue Oct 21, 2022 · 0 comments
Open

Fix /champions #9

Bekabyx opened this issue Oct 21, 2022 · 0 comments

Comments

@Bekabyx
Copy link
Owner

Bekabyx commented Oct 21, 2022

Champions is not currently working as expected - it's returning all finalists.

I'd like to overhaul this to be based off of Year in its initial query and have a format like

{
    "year": 2022,
    "bracket_date": "2022-10-11",
    "contestants": {
        /* basic bear serializer here */
    }
}

Obviously, I'd also like to address the broken logic.

I'd also like to overhaul the (currently working) Finalists endpoint to use this same format. In this case, the contestants field should be a list rather than a single object.

May need some more thought to maximise code reuse and cleanliness, but jotting my ideas down here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant