Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port UnhollowerPdbGen to Il2CppInterop #155

Closed
wants to merge 2 commits into from

Conversation

ds5678
Copy link
Collaborator

@ds5678 ds5678 commented Sep 8, 2024

Original source: https://github.com/knah/Il2CppAssemblyUnhollower/tree/ea4ff499b2bd902de8ef2de3d132278cbb86ae4f/UnhollowerPdbGen

Modifications:

  • Use Il2CppInterop.Common instead of UnhollowerBaseLib
  • Use AsmResolver instead of Mono.Cecil
  • Use .NET 9 instead of .NET 5
  • Use AssetRipper.Bindings.MsPdbCore.
  • Formatting

Resolves #105

@ds5678 ds5678 added the enhancement New feature or request label Sep 8, 2024
@ds5678 ds5678 added this to the 1.5.0 milestone Sep 8, 2024
@ds5678 ds5678 requested a review from Kasuromi September 8, 2024 17:25
@ds5678 ds5678 force-pushed the pdb-generator branch 4 times, most recently from 291bc7b to a2c57b1 Compare September 14, 2024 19:10
@ds5678 ds5678 removed this from the 1.5.0 milestone Oct 5, 2024
@Kasuromi
Copy link
Member

The general consensus when we picked the project up was to remove the pdb generation as it was deemed useless and used a proprietary windows only pdb library. I believe we were expecting Cpp2IL to deal with the pdb generation for us at one point or another. We can carry over the discussion on whether or not this feature is necessary for the time being on discord.

Relevant discord messages: here

@ds5678
Copy link
Collaborator Author

ds5678 commented Nov 28, 2024

Superceded by SamboyCoding/Cpp2IL#382

@ds5678 ds5678 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdb support?
2 participants