Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to create new types? #2

Open
morenol opened this issue Oct 14, 2022 · 1 comment
Open

Open to create new types? #2

morenol opened this issue Oct 14, 2022 · 1 comment

Comments

@morenol
Copy link
Contributor

morenol commented Oct 14, 2022

I would like to add more types . But also would like to rename fields to follow rust naming convention. We can use:

#[serde(rename_all = "camelCase")]

instead

does that sound good?

@Billy-Sheppard
Copy link
Owner

As long as it doesn't break existing functionality I'm happy! I think there might've been a reason I didn't use rename_all in the first place but I can't recall it.

Please PR this and I should be able to help with testing when its ready.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants