-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise default param registration #119
Comments
Just wanted to leave my two cents here as we had already some issues with this too (referring to: drisso/zinbwave#38 (comment)). As of my knowledge BiocParallel ignores SLURM, Snakemake or other job scheduler which provides number of cores to be used (which would be a nice feature request). Hence, if you do not specify this in your code on the user side explicitly you overcommit on cpu and memory by default, which usually ends in termination of your job (at least on SLURM where memory limits are enforced). So instead of relying on |
@c-mertes I think the BatchtoolsParam() is appropriate for use on SLURM; the vignette 'Introduction to BatchtoolsParam' discusses the registryargs parameter and use of templates for controlling use of cores. |
Sorry for not being too clear on this @mtmorgan. |
@c-mertes I think you are talking about an unrelated issue. This issue is about switching from parallelization using forking to non-forking parallelization, not changing the default number of cores. |
With regard to parallelization in RStudio, BiocParallel could borrow the logic used in future: https://github.com/HenrikBengtsson/future/blob/develop/R/supportsMulticore.R#L71-L91 |
MulticoreParam() is appealing for interactive use, but problematic in package use, as discussed eg drisso/zinbwave#38 (comment). Update default strategy to use SnowParam() as the default.
The text was updated successfully, but these errors were encountered: