Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Add rmg network parameters #6

Open
tylerlevine opened this issue Aug 16, 2018 · 1 comment
Open

Add rmg network parameters #6

tylerlevine opened this issue Aug 16, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@tylerlevine
Copy link
Contributor

It would be nice to pull these parameters out of prova and into bitgo-utxo-lib. For reference:
(prova-lib/src/networks.js)

module.exports = {
  rmg: {
    messagePrefix: '\x18RMG Signed Message:\n',
    bip32: {
      public: 0x0488b21e,
      private: 0x0488ade4
    },
    rmg: 0x33, // starts with G
    wif: 0x80
  },
  rmgTest: {
    messagePrefix: '\x18RMG Test Signed Message:\n',
    bip32: {
      public: 0x0488b21e,
      private: 0x0488ade4
    },
    rmg: 0x58, // starts with T
    wif: 0x80
  },
  litecoinTest: {
    magic: 0xd9b4bef9,
    messagePrefix: '\x19Litecoin Signed Message:\n',
    bip32: {
      public: 0x0488b21e,
      private: 0x0488ade4
    },
    pubKeyHash: 0x6f,
    scriptHash: 0x3a,
    wif: 0xb0,
    dustThreshold: 0, // https://github.com/litecoin-project/litecoin/blob/v0.8.7.2/src/main.cpp#L360-L365
    dustSoftThreshold: 100000, // https://github.com/litecoin-project/litecoin/blob/v0.8.7.2/src/main.h#L53
    feePerKb: 100000 // https://github.com/litecoin-project/litecoin/blob/v0.8.7.2/src/main.cpp#L56
  }
};

Also, I'm not sure why litecoinTest is there, but I noted that it's missing from bitgo-utxo-lib as well and should probably be added.

@argjv
Copy link
Contributor

argjv commented Nov 29, 2018

I'm not entirely sure RMG is supported out of the box. I believe litecoin test is but we should add some tests when adding new networks.

@argjv argjv added the good first issue Good for newcomers label Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants
@argjv @tylerlevine and others