Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull coinDecimals from BitGoJS.statics #61

Open
cooncesean opened this issue Nov 26, 2019 · 1 comment
Open

Pull coinDecimals from BitGoJS.statics #61

cooncesean opened this issue Nov 26, 2019 · 1 comment
Labels
1 code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant.

Comments

@cooncesean
Copy link
Contributor

Overview

If you look at sign.js, it defines a configuration constants for each coin that the library supports.

These constants are already defined in the upstream library, BitGoJs; there is no need to create two sources of the truth.

The task: Update this library to leverage the existing constants in BitGoJS.statics.

Definition of Done

  • Refactor all coins to fetch their constants from BitGoJS.statics.
  • All tests should still pass after these changes.

Extra Credit

Are there any other constants in this library that have already been defined in BitGoJS.statics? If so, please add or create a new issue to track it -- if not, do you see any constants that might be useful to move upstream?
@cooncesean cooncesean added the 1 label Nov 26, 2019
@cooncesean cooncesean added the code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant. label Dec 4, 2019
@neharac8 neharac8 mentioned this issue Mar 3, 2020
Closed
wellkochi added a commit to wellkochi/key-recovery-service-v2 that referenced this issue Mar 16, 2020
@wellkochi
GetCoin alias
1730b1b 
Using getCoinConfig(coin, data) instead of statics.coins.get[coin].data
BitGo#61
@wellkochi
Copy link

#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Used the existing constants in BitGoJS.statics neharac8/key-recovery-service-v2
2 participants
@cooncesean @wellkochi