From 26b68cf7441f6fe31fcd371e390dcf8aa0067b48 Mon Sep 17 00:00:00 2001
From: PiRK <pierrekn@gmail.com>
Date: Wed, 5 Apr 2023 09:40:54 +0200
Subject: [PATCH] [flynt] remove buggy  --transform-concats option

Summary:
See https://github.com/ikamensh/flynt/issues/173

The linter will still be able to convert "%"-formatted strings  and `"{}".format(` occurences to f-strings.
It will no longer simplify string concatenations.

Test Plan:
Touch test_runner.py and make sure `arc lint` does not clear the file.

Add actual lines that flynt will update, and check that the changes from `arc lint` is as expected. E.g:
```
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 38ac427eeb..079079e3bb 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -163,6 +163,9 @@ class TestCase:
         self.test_num = test_num
         self.failfast_event = failfast_event
         self.flags = flags
+        a = "%s " % "toto"
+        b = "{}".format(a)
+        print(a + b)

     def run(self):
         if self.failfast_event.is_set():
```

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13573
---
 .arclint | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/.arclint b/.arclint
index 0409f68ccc..607011eb17 100644
--- a/.arclint
+++ b/.arclint
@@ -304,10 +304,7 @@
             "type": "lint-python-flynt",
             "version": ">=0.78",
             "include": "(\\.py$)",
-            "exclude": "(^contrib/)",
-            "flags": [
-                "--transform-concats"
-            ]
+            "exclude": "(^contrib/)"
         }
     }
 }