-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/operator restrictions #4
base: feat/generic-sanity-checks
Are you sure you want to change the base?
Changes from 4 commits
6a9cd63
305fe99
74b3fe4
f7620c6
f514692
9650e28
c77178c
e2bf7f6
de85df4
8009baa
a396f4c
9aaac8a
f762069
410a120
2f7baa3
a419357
99211c4
aa21e29
1646350
c8ede00
a9af474
8821760
44d6b9f
edee642
5479a53
7ea9136
583ae79
3010816
9ed479a
52a9bea
5d1d7e3
a09b9b1
dd87423
5c9f6b5
d2a300a
efe5a3b
48d19f2
caa07f0
564a5e4
20e8888
6a6b68f
caf8f71
6af3d10
31880f4
ccaaaf0
4508197
c4921e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,26 @@ library OrderEngine { | |
bytes predicates; | ||
bytes preInteraction; | ||
bytes postInteraction; | ||
bytes signature; | ||
} | ||
|
||
bytes32 public constant ORDER_TYPE_HASH = | ||
keccak256( | ||
"Order(" | ||
"uint256 nonce," | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we use smaller datatype for nonce ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I'm considering this. Actually, we can consider using smaller types for the following variables: nonce, validTill, sellTokenAmount, buyTokenAmount, and feeAmounts |
||
"uint256 validTill," | ||
"uint256 sellTokenAmount," | ||
"uint256 buyTokenAmount," | ||
"uint256 feeAmounts," | ||
"address maker," | ||
"address taker," | ||
"address recipient," | ||
"address sellToken," | ||
"address buyToken," | ||
"bool isPartiallyFillable," | ||
"bytes32 extraData," | ||
"bytes predicates," | ||
"bytes preInteraction," | ||
"bytes postInteraction" | ||
")" | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xhammadghazi
The natspec for signatures seems missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acknowledged