-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return views to C++ objects instead of copies #367
Comments
Which calls are you specifically thinking about? |
(oops, just checked, |
As far as I can remember, #359 was done because the |
Very good point, we'll look into it. One thing we have to be careful about is making sure that the python bindings aren't a |
* fixes #367 * very gross; need to use pybind11::detail to be able to touch the flags
I have made an attempt to build on top of Mike's initial implementation in #373 . The lifetimes, refcounts, etc. all seem to work except for the Vasculature's last section, which seems to exhibit an issue with its refcount. |
As far as I can see, the Python bindings of the functions and methods of MorphIO return copies of C++ data instead of views to these data. It seems possible to return views: pybind/pybind11#2271 which would probably improve performance and reduce memory usage.
The text was updated successfully, but these errors were encountered: