Get voltage via prop->node.
#1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
- Coverage 86.59% 86.55% -0.04%
==========================================
Files 182 182
Lines 13552 13581 +29
==========================================
+ Hits 11735 11755 +20
- Misses 1817 1826 +9 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/uniform-node-data
branch
from
bc538a6 to
2467e24
Compare
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/uniform-node-data
branch
from
2467e24 to
7de2957
Compare
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/uniform-node-data
branch
from
1eb4178 to
1bfa714
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 4, 2024
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/uniform-node-data
branch
from
1bfa714 to
df3caa2
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 4, 2024
This comment has been minimized.
This comment has been minimized.
When calling functions directly, don't have access to the `NrnThread` and therefore can't get node properties, like the voltage from there. The solution is to create a link from the Prop to the Node. Then use that link to figure out the node properties. The trick to make the two cases uniform is the same as we use for instance data, we create pointers to array of length one (by taking the address of the element) and setting `_iml`/`id` to `0`.
1uc
force-pushed
the
1uc/uniform-node-data
branch
from
df3caa2 to
bcef74f
Compare
matz-e
reviewed
Sep 4, 2024
matz-e
approved these changes
Sep 4, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 4, 2024
|
Logfiles from GitLab pipeline #230035 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling functions directly, don't have access to the
NrnThreadand therefore can't get node properties, like the voltage from there.
The solution is to create a link from the Prop to the Node. Then use
that link to figure out the node properties.
The trick to make the two cases uniform is the same as we use for
instance data, we create pointers to array of length one (by taking the
address of the element) and setting
_iml/idto0.