Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get voltage via prop->node. #1414

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Get voltage via prop->node. #1414

merged 8 commits into from
Sep 9, 2024

Commits on Sep 4, 2024

  1. Get voltage via prop->node. 

    When calling functions directly, don't have access to the `NrnThread`
and therefore can't get node properties, like the voltage from there.

The solution is to create a link from the Prop to the Node. Then use
that link to figure out the node properties.

The trick to make the two cases uniform is the same as we use for
instance data, we create pointers to array of length one (by taking the
address of the element) and setting `_iml`/`id` to `0`.
    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    db36800 View commit details
    Browse the repository at this point in the history

  2. Artificial cells aren't associated with a node.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cc671d8 View commit details
    Browse the repository at this point in the history

  3. Support top LOCALs in non-vectorized MOD files.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    22067a7 View commit details
    Browse the repository at this point in the history

  4. Test function calls with non-threadsafe MOD files.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    81ad83b View commit details
    Browse the repository at this point in the history

  5. Test globals in non-VECTORIZED MOD files.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2239c73 View commit details
    Browse the repository at this point in the history

  6. Improve function calling coverage.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    67b0792 View commit details
    Browse the repository at this point in the history

  7. Test function calls for ARTIFICIAL_CELLs.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bcef74f View commit details
    Browse the repository at this point in the history

  8. Remove debugging output.

    @1uc
    1uc committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a8d0e45 View commit details
    Browse the repository at this point in the history