feat: add support for Linptech RS1BB(MI) #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ernst79
reviewed
May 5, 2024
|
sorry, also without the |
Ernst79
reviewed
May 5, 2024
Ernst79
reviewed
May 5, 2024
|
Almost there, only some linting issues, just follow the suggested changes. |
kvakulo
changed the title
|
Nice work, thanks. |
Ernst79
approved these changes
May 5, 2024
|
Thanks for the live assistance with this PR, @Ernst79, I really appreciate it! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add support for RS1BB(MI) in xiaomi-ble.
I'm not sure what is the best way to test this change, but I try to raise the PR anyway and will try to explore how to test it out.
This PR is based on the change made in ble_monitor by @Ernst79: custom-components/ble_monitor@2b5e8ea