pi-apps will not install apps with urxvt

[Silent-Hunter]

Confirmations

• I searched for similar bug reports in https://github.com/Botspot/pi-apps/issues and found none were relevant.
• I tried updating Pi-Apps and the issue is still not fixed. How to update Pi-Apps?
• IMPORTANT: I promise to respond to comments on this issue and write a good bug report https://www.softwaretestinghelp.com/how-to-write-good-bug-report/

What happened?

pi-apps will not install apps with urxvt.

Description

When I try to install any app, pi-apps opens a window containing the text below:

Debug output below.
Default x-terminal-emulator: urxvt
�[91mFailed to locate any terminal emulators!!!�[39m

I was able to mitigate it by adding urxvt after line 37 of terminal-run, and then adding this after line 97:

  xterm -e bash -c "$commands" &

What are your system specs (run the following command in your terminal)?

OS: Debian GNU/Linux 11 (bullseye)
OS architecture: 64-bit
Last updated Pi-Apps on: 10/22/2023
Latest Pi-Apps version: 10/22/2023
Kernel: aarch64 6.1.21-v8+
Device model: Raspberry Pi 4 Model B Rev 1.5 
Cpu name: Cortex-A72
Ram size: 7.63 GB
Raspberry Pi OS image version: 2022-09-22
Language: en_US.UTF-8

(Recommended) Error log? Terminal output? Debug messages?

🭊🬹🬹🬹🬿                                                          
 🭇🬭🬭🬎🬭🬭🬭🬎🬭🬭🬼                                                       
 🮉  ▄ ▄ ▄  ▋   █▀▀🭍 ▄                                              
 🮉  ▄ ▄ ▄  ▋   █▄▄🭞 ▄ ▄▄ 🭂▀▀█ █▀▀🭍 █▀▀🭍 🭂🬰🬰🬰                       
 🮉  ▄ ▄ ▄  ▋   █    █    🭓▄▄█ █▄▄🭞 █▄▄🭞 ▄▄▄🭞                       
 🭦🭏🬭🬭🬭🬭🬭🬭🬭🭄🭛                  █    █                               
                                                                   
                                                                   
pipe is /tmp/tmp.FjuiClns4i
detailspid is /tmp/tmp.fizqJtilJZ
tail: warning: --retry only effective for the initial open

Updater mode: set-status

Checking for online changes... Done
Timestamps match.
Reading list file for ''...
Scanning apps... Done
Scanning files... Done
cat: /home/kavus/pi-apps/data/update-status/updatable-apps: No such file or directory
YAD_XID is 0x2800003
Timestamps match.
Reading list file for 'Games'...
YAD_XID is 0x2800003
Failed to locate any terminal emulators!!!

[github-actions]

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

[Botspot]

Do you have any terminal emulators other than urxvt installed?

[Silent-Hunter]

No I don't, it's the only one I use. I can install another to help test if need be.

[Botspot]

I can install another to help test if need be.

The list of supported terminals in the terminal-run script are treated as a fallback: if your preferred terminal (as chosen by x-terminal-emulator) is not in the list, then terminal-run will check if any other supported terminal is installed.

In other words, you are encountering this problem because you have uninstalled all other terminal emulators. If you had a supported terminal emulator installed, then terminal-run would use that one.
I will look into adding urxvt to terminal-run properly.

[Botspot]

I have added urxvt to terminal-run in commit 8e2f2bb.

Please update pi-apps manually by running ~/pi-apps/updater cli-yes. Then once that is done, you should be able to use pi-apps normally with your choice of terminal.

Thanks again for taking the time to reach out for help on this issue! Your issue report has made pi-apps just a little bit better for everyone. :)

[Sussy-OS]

I have added urxvt to terminal-run in commit 8e2f2bb.

Please update pi-apps manually by running ~/pi-apps/updater cli-yes. Then once that is done, you should be able to use pi-apps normally with your choice of terminal.

Thanks again for taking the time to reach out for help on this issue! Your issue report has made pi-apps just a little bit better for everyone. :)

When updating via GUI, it provides an error. The error does not cause any problem, but it may throw some users off.

[Botspot]

When updating via GUI, it provides an error. The error does not cause any problem, but it may throw some users off.

What do you mean? What error? Did you see an error when updating terminal-run on your system, @Sussy-OS?

[Sussy-OS]

When updating via GUI, it provides an error. The error does not cause any problem, but it may throw some users off.

What do you mean? What error? Did you see an error when updating terminal-run on your system, @Sussy-OS?

Yes, I did. I'm not sure exactly what it said, but I'll downgrade pi-apps and try again so I can get the error.

[Sussy-OS]

Unable to open a terminal.
Debug output below.
Default x-terminal-emulator: lxterminal
Using lxterminal

[Sussy-OS]

Here is the actual issue:

/home/james/pi-apps/etc/terminal-run: line 124: syntax error near unexpected token `do'
/home/james/pi-apps/etc/terminal-run: line 124: `/${terminalrun_pid} ];do'

[Sussy-OS]

I'm sure that line is intended, it's just causing an error for me. Restarting fixes the problem.

[Silent-Hunter]

Thanks again for taking the time to reach out for help on this issue! Your issue report has made pi-apps just a little bit better for everyone. :)

Thank you for fixing the issue!

[Botspot]

Here is the actual issue:

/home/james/pi-apps/etc/terminal-run: line 124: syntax error near unexpected token `do'
/home/james/pi-apps/etc/terminal-run: line 124: `/${terminalrun_pid} ];do'

I know what happened. This can happen when a running script gets updated while it is running. Bash can lose track of where it was and get confused when the next lines of the file do not match what it was expecting. In the new commit f1b643b, I have encased the entire terminal-run script in {} characters to force bash to read the whole file on startup. Even one-time errors are important. Thanks for reporting, @Sussy-OS.

[Sussy-OS]

Here is the actual issue:

/home/james/pi-apps/etc/terminal-run: line 124: syntax error near unexpected token `do'
/home/james/pi-apps/etc/terminal-run: line 124: `/${terminalrun_pid} ];do'

I know what happened. This can happen when a running script gets updated while it is running. Bash can lose track of where it was and get confused when the next lines of the file do not match what it was expecting. In the new commit f1b643b, I have encased the entire terminal-run script in {} characters to force bash to read the whole file on startup. Even one-time errors are important. Thanks for reporting, @Sussy-OS.

Oh, okay. No problem.