Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to push branch #34

Open
JohanDelvaux opened this issue Mar 24, 2023 · 2 comments
Open

not able to push branch #34

JohanDelvaux opened this issue Mar 24, 2023 · 2 comments

Comments

@JohanDelvaux
Copy link

JohanDelvaux commented Mar 24, 2023

Hi BrannonKing,

I made a small extension to your library in a local branch, which I would like push to Github and create a PR, but I think I do not have permission to do so?

(According to LGPL I need to make changes public so would prefer if I can just add them here instead of creating a fork. I guess you might also make a new Nuget package available at a certain point for other to use?)

Thanks,
Johan

@BrannonKing
Copy link
Owner

You need to fork the repo first. Then make a new branch in that containing your changes. Then make a pull request from that branch back into the master branch here. If the change is not applicable to general audiences, you can just keep it in your (public) fork; that is sufficient for LGPL.

@JohanDelvaux
Copy link
Author

Ok BrannonKing. I created a fork and committed my changes to my master branch. (https://github.com/JohanDelvaux/NLoptNet/tree/master) I think it might be useful for other people as well although it's really quite small.
Let me know if you want me to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants