Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brick:Collection subclassOf rec:Collection, refactor/deprecate? #671

Open
PeteHart opened this issue Oct 24, 2024 · 2 comments
Open

brick:Collection subclassOf rec:Collection, refactor/deprecate? #671

PeteHart opened this issue Oct 24, 2024 · 2 comments

Comments

@PeteHart
Copy link

@gtfierro

As mentioned in latest coordination meeting we've noted that the brick:Collections is a subclass of the rec:Collection

Wonder if the brick:Collection is really needed as removing it (deprecating it) would lead to a straighter class hierarchy!?

If it's due to some relationships or properties not present on the rec:Collection we'd be happy to try to solve by upgrading the rec:Collection accordingly

Best Peter

@gtfierro
Copy link
Member

Hi @PeteHart . We discussed this a little today and I think removing the Brick Collection would be a good idea. I'm in agreement with your comment in #672 , and using includes for Systems would feel more consistent. This is definitely a Brick 1.5 change, but we can make it available sooner through a Brick 1.5 pre-builds (available on #658)

@PeteHart
Copy link
Author

Perfekt @gtfierro, when in time, roughly, do you envision a Brick 1.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants