Add rubycritic and sandi meter #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jorge27
reviewed
Nov 26, 2020
There was a problem hiding this comment.
Sandimeter will be change continuously, this can affect your rubycritic score. As a tip, you can add the sandimeter folder and add it to gitignore, create another folder where you can put a screenshot of the progress of the sandimeter or configure rubycritic in the Rakefile to exclude the sandimeter directory
Check the documentation in github
| @@ -5,7 +5,8 @@ | |||
| # git config --global core.excludesfile '~/.gitignore_global' | |||
|
|
|||
| #Ignore sandimeter | |||
| /sandi_meter/ | |||
| *.sandi_meter | |||
There was a problem hiding this comment.
Can you also remove all added sandi_meter files from the previous commits? 😄
There was a problem hiding this comment.
They aren't really needed
jorge27
previously approved these changes
Nov 26, 2020
jaimelr
reviewed
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
None.
Screenshots
None.