From 3c88f6695e6646b4fc5f72a6bfd4327d6c4e07dc Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Tue, 24 Dec 2024 00:28:23 -0500 Subject: [PATCH] MM-62344 Disable mouse-events-have-key-events ESLint rule (#29654) This rule warns us if an element has an onMouseOver/onMouseLeave attributes without corresponding onFocus/onBlur ones. It's helpful for showing where we may be missing some accessible interactions, and I've filed MM-62343 and MM-62345 to follow up on two of these. In other cases, the component either has alternate accessibility support (the emoji picker), it's something that may not make sense to be accessible (the expanded view of the channel header), or something we're already planning to review accessiblity for (the search component), so I'm going to disable it to avoid introducing noise for the time being. --- webapp/platform/eslint-plugin/configs/.eslintrc-react.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/platform/eslint-plugin/configs/.eslintrc-react.json b/webapp/platform/eslint-plugin/configs/.eslintrc-react.json index a6afa3f9046..5d938cd8c64 100644 --- a/webapp/platform/eslint-plugin/configs/.eslintrc-react.json +++ b/webapp/platform/eslint-plugin/configs/.eslintrc-react.json @@ -31,7 +31,7 @@ "jsx-a11y/interactive-supports-focus": "warn", "jsx-a11y/label-has-associated-control": "error", "jsx-a11y/media-has-caption": "warn", - "jsx-a11y/mouse-events-have-key-events": "warn", + "jsx-a11y/mouse-events-have-key-events": "off", "jsx-a11y/no-access-key": "error", "jsx-a11y/no-aria-hidden-on-focusable": "error", "jsx-a11y/no-autofocus": "warn",