From 527beac1b77a7d23f32435d6a32126892cfe6ce3 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-884 Date: Wed, 11 Dec 2024 19:18:56 +0530 Subject: [PATCH] [MA-16]: Ensure the Add button is accessible with keyboard --- .../add_groups_to_channel_modal.tsx | 4 ++-- .../add_groups_to_team_modal/add_groups_to_team_modal.tsx | 4 ++-- .../multiselect_option/multiselect_option.tsx | 4 ++-- .../add_users_to_team_modal/add_users_to_team_modal.tsx | 4 ++-- .../add_users_to_role_modal/add_users_to_role_modal.tsx | 4 ++-- .../components/channel_invite_modal/channel_invite_modal.tsx | 4 ++-- .../channel_selector_modal/channel_selector_modal.tsx | 4 ++-- .../components/more_direct_channels/list_item/list_item.tsx | 4 ++-- .../components/team_selector_modal/team_selector_modal.tsx | 4 ++-- webapp/channels/src/sass/components/_modal.scss | 3 ++- 10 files changed, 20 insertions(+), 19 deletions(-) diff --git a/webapp/channels/src/components/add_groups_to_channel_modal/add_groups_to_channel_modal.tsx b/webapp/channels/src/components/add_groups_to_channel_modal/add_groups_to_channel_modal.tsx index 8383269c5a19..910d377d5585 100644 --- a/webapp/channels/src/components/add_groups_to_channel_modal/add_groups_to_channel_modal.tsx +++ b/webapp/channels/src/components/add_groups_to_channel_modal/add_groups_to_channel_modal.tsx @@ -216,9 +216,9 @@ export class AddGroupsToChannelModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/add_groups_to_team_modal/add_groups_to_team_modal.tsx b/webapp/channels/src/components/add_groups_to_team_modal/add_groups_to_team_modal.tsx index 82de21a55692..588e11624792 100644 --- a/webapp/channels/src/components/add_groups_to_team_modal/add_groups_to_team_modal.tsx +++ b/webapp/channels/src/components/add_groups_to_team_modal/add_groups_to_team_modal.tsx @@ -223,9 +223,9 @@ export class AddGroupsToTeamModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/add_user_to_group_multiselect/multiselect_option/multiselect_option.tsx b/webapp/channels/src/components/add_user_to_group_multiselect/multiselect_option/multiselect_option.tsx index ceb6c98bc101..4d8d66d61ce2 100644 --- a/webapp/channels/src/components/add_user_to_group_multiselect/multiselect_option/multiselect_option.tsx +++ b/webapp/channels/src/components/add_user_to_group_multiselect/multiselect_option/multiselect_option.tsx @@ -56,11 +56,11 @@ const MultiSelectOption = React.forwardRef(({
-
+
+
); diff --git a/webapp/channels/src/components/add_users_to_team_modal/add_users_to_team_modal.tsx b/webapp/channels/src/components/add_users_to_team_modal/add_users_to_team_modal.tsx index cef90a33679b..ed375bba142b 100644 --- a/webapp/channels/src/components/add_users_to_team_modal/add_users_to_team_modal.tsx +++ b/webapp/channels/src/components/add_users_to_team_modal/add_users_to_team_modal.tsx @@ -135,11 +135,11 @@ export class AddUsersToTeamModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/admin_console/system_roles/system_role/add_users_to_role_modal/add_users_to_role_modal.tsx b/webapp/channels/src/components/admin_console/system_roles/system_role/add_users_to_role_modal/add_users_to_role_modal.tsx index 8e3fbb6d1308..ec0939d8e43a 100644 --- a/webapp/channels/src/components/admin_console/system_roles/system_role/add_users_to_role_modal/add_users_to_role_modal.tsx +++ b/webapp/channels/src/components/admin_console/system_roles/system_role/add_users_to_role_modal/add_users_to_role_modal.tsx @@ -137,11 +137,11 @@ export class AddUsersToRoleModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/channel_invite_modal/channel_invite_modal.tsx b/webapp/channels/src/components/channel_invite_modal/channel_invite_modal.tsx index f10edda8dbfe..417f59853cdd 100644 --- a/webapp/channels/src/components/channel_invite_modal/channel_invite_modal.tsx +++ b/webapp/channels/src/components/channel_invite_modal/channel_invite_modal.tsx @@ -425,11 +425,11 @@ export class ChannelInviteModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/channel_selector_modal/channel_selector_modal.tsx b/webapp/channels/src/components/channel_selector_modal/channel_selector_modal.tsx index b20ce01f3b72..7152fb3b0100 100644 --- a/webapp/channels/src/components/channel_selector_modal/channel_selector_modal.tsx +++ b/webapp/channels/src/components/channel_selector_modal/channel_selector_modal.tsx @@ -186,9 +186,9 @@ export class ChannelSelectorModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/components/more_direct_channels/list_item/list_item.tsx b/webapp/channels/src/components/more_direct_channels/list_item/list_item.tsx index ef84121c1a8e..53d8e5eba2c3 100644 --- a/webapp/channels/src/components/more_direct_channels/list_item/list_item.tsx +++ b/webapp/channels/src/components/more_direct_channels/list_item/list_item.tsx @@ -75,9 +75,9 @@ const ListItem = React.forwardRef((props: Props, ref?: React.Ref }
-
+
+
); diff --git a/webapp/channels/src/components/team_selector_modal/team_selector_modal.tsx b/webapp/channels/src/components/team_selector_modal/team_selector_modal.tsx index bcb0fb41a91e..5026ed3082eb 100644 --- a/webapp/channels/src/components/team_selector_modal/team_selector_modal.tsx +++ b/webapp/channels/src/components/team_selector_modal/team_selector_modal.tsx @@ -190,9 +190,9 @@ export class TeamSelectorModal extends React.PureComponent {
-
+
+
); diff --git a/webapp/channels/src/sass/components/_modal.scss b/webapp/channels/src/sass/components/_modal.scss index ecc4b9368eae..caee211a0647 100644 --- a/webapp/channels/src/sass/components/_modal.scss +++ b/webapp/channels/src/sass/components/_modal.scss @@ -931,11 +931,12 @@ .more-modal__actions--round { display: none; + border: none; width: 32px; height: 32px; - line-height: 32px; opacity: 0.75; text-align: center; + padding: 0 } .more-modal__right {