Add workspace stack

[JohnCoene]

I don't understand this line

blockr/R/workspace.R

Line 109 in 5f169ea

if (!isTRUE(force) && name %in% list_workspace_stacks(workspace)) {

If force is not TRUE and that the stack is already found in the workspace we emit a warning. Shouldn't it instead not overwrite the stack in the workspace if the stack is already found in the workspace rather than just emit a warning?

[JohnCoene]

Also, I don't understand the difference with set_workspace_stack

blockr/R/workspace.R

Line 120 in 5f169ea

set_workspace_stack <- function(name, stack, force = FALSE,

[nbenn]

@JohnCoene happy to be more strict here and promote the warning(s) to error(s). As to "what is the difference": "add" is meant to add a new stack, while "set" was thought for updating an existing stack. Happy to rename set_workspace_stack() to make this clearer.

[JohnCoene]

@nbenn Thank you.

My question is because 1) both functions are identical as far as I can tell so add == set and 2) if force = FALSE then the function still performs the action, only with a warning.

It may be me but I would expect set_workspace_stack to not create a new stack in the workspace if it is not found.