Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken join block #441

Closed
JohnCoene opened this issue Oct 22, 2024 · 5 comments
Closed

Broken join block #441

JohnCoene opened this issue Oct 22, 2024 · 5 comments
Labels

Comments

@JohnCoene
Copy link
Member

Join block is broken as far as I can tell.

@DivadNojnarg is it needed for workshop?

library(blockr)
library(shiny)

dat1_stack <- new_stack(
  new_dataset_block(selected = "iris"),
  name = "dat1",
  title = "First dataset"
)

dat2_stack <- new_stack(
  new_dataset_block(selected = "iris"),
  name = "dat2",
  title = "Second dataset"
)

merged_stack <- new_stack(
  new_result_block("dat1"),
  new_join_block(y = "dat2", type = "left", by = "Species")
)

ui <- fluidPage(
  theme = bslib::bs_theme(5L),
  div(
    class = "row",
    div(
      class = "col-md-6",
      generate_ui(dat1_stack)
    ),
    div(
      class = "col-md-6",
      generate_ui(dat2_stack)
    )
  ),
  generate_ui(merged_stack)
)

server <- function(input, output, session) {
  generate_server(dat1_stack)
  generate_server(dat2_stack)
  generate_server(merged_stack)
}

shinyApp(ui, server)
@DivadNojnarg
Copy link
Collaborator

Yes that's a consequence of the result block issue in #439 and #432. We don't need it for the workshop but that's still high priority.

@JohnCoene
Copy link
Member Author

@DivadNojnarg which version should I revert to so that it works? I need to deploy a demo app with joins.

@DivadNojnarg
Copy link
Collaborator

I did not released the very latest main so you can use this one: https://github.com/BristolMyersSquibb/blockr/releases/tag/v0.0.2.9023.

@karmatarap
Copy link

@DivadNojnarg. Please can we fix this as a priority as it is one of the key selling points for the demos (PhuUSE EU + internal)

@nbenn
Copy link
Collaborator

nbenn commented Oct 28, 2024

This is the same issue as #432 and is being addressed with highest priority. I'm closing here in favor of #432.

@nbenn nbenn closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants