Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is has parameter a object property? #12

Open
wdduncan opened this issue Sep 19, 2021 · 1 comment
Open

why is has parameter a object property? #12

wdduncan opened this issue Sep 19, 2021 · 1 comment

Comments

@wdduncan
Copy link
Member

Why is has parameter an object property where has MRI sequence parameter is a data property? Perhaps it would be better to be consistent on the use of object and data properties?

@adbartni
Copy link
Contributor

I agree the naming makes this pretty unclear. has MRI sequence parameter really deals in the realm of MRI machine setting datum values, and not necessarily with the MRI sequence parameters themselves. The subclasses of has MRI sequence parameter reflect this and are meant to assign the values of flip angle, TE, TR, and TI to an individual acquisition sequence, which are external values set at the MRI machine by a technician.

I propose changing the name of has MRI sequence parameter to has MRI machine setting value and adding a definition to make this more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants