Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve share modal closing UX #94

Open
swellander opened this issue Jul 23, 2024 · 2 comments
Open

Improve share modal closing UX #94

swellander opened this issue Jul 23, 2024 · 2 comments

Comments

@swellander
Copy link
Collaborator

Right now users can only close the Share modal by clicking the "Close" button. For better UX, the modal should also close when

  1. The user clicks anywhere outside the modal
  2. The user presses the escape button
@Franpastoragusti Franpastoragusti self-assigned this Jul 24, 2024
@swellander
Copy link
Collaborator Author

@Franpastoragusti are you working on this? I can take it if not

@Franpastoragusti Franpastoragusti removed their assignment Aug 6, 2024
@KcPele
Copy link
Contributor

KcPele commented Aug 6, 2024

working on this

@KcPele KcPele mentioned this issue Aug 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Franpastoragusti @swellander @KcPele