Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning in Django 3.0 #35

Open
ethanjahn opened this issue Dec 16, 2019 · 0 comments
Open

Deprecation Warning in Django 3.0 #35

ethanjahn opened this issue Dec 16, 2019 · 0 comments

Comments

@ethanjahn
Copy link

Hi Team,

Thanks for the project, it works really well when working with Auth0!

I recently upgraded to django 3.0 which is deprecating django.utils.encoding.smart_text() in favor of django.utils.encoding.smart_str()

I think think smart_str() works as a drop-in replacement for the smart_text() call in line 59 of authentication.py. The only difference between the two is that smart_str() keeps lazy objects as lazy objects, and smart_text() resolves lazy objects to strings.

Happy to submit a PR if you agree that this would not have any unexpected consequences.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant