Implement settings - edit profile #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shalandy
requested changes
Jun 13, 2020
There was a problem hiding this comment.
I'm getting this error on the following data :( (see below, password: test123)
I looked into the code and honestly not sure why user.name seems to be null in this instance, because I saw that you already did make the check of user not being null—my only suggestion is maybe try using the getName() function from the User class? Although I wouldn't be sure why it seems to be working on your end with the same code/maybe cached somehow 😮 feel free to try on my sample account
shalandy
previously approved these changes
Jun 13, 2020
|
thank you for review!! overflow should be fixed now! |
shalandy
approved these changes
Jun 13, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: Implement edit profile capabilities --> connected to Firebase
Screenshots:
Edited screens:
• hub_screen: implemented UI + backend for editing profile under 'Profile' --> 'Settings' tab
New widgets:
• EditFormField: TextField for editing profile
Edited data models:
• User: added phoneNumber instance variable
New assets (1):
• edit_button.png